Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newer electron versions #3702

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dudewheresmycode
Copy link

Adds current stable electron versions to the TC build utils.

Related Issue: #3701

@lissyx
Copy link
Collaborator

lissyx commented Nov 10, 2021

Thanks @dudewheresmycode, do you have a successfull run of GitHub Actions to show ?

@dudewheresmycode
Copy link
Author

dudewheresmycode commented Nov 11, 2021

@lissyx I'm not that familiar with the GitHub Actions workflow of this project. But, I think I was able to get a (mostly) successful run on my fork here:
https://github.com/dudewheresmycode/DeepSpeech/actions/runs/1451548491

I was able to get a clean build for MacOS of the electron binaries. But hit some errors on Windows and Linux builds. Hoping you can advise there.

Note: I had to update the URL for PCRE (it was timing out during builds), not sure if I should keep that change or not. I saw a couple other failures, but I think the relevant bits passed.

@lissyx
Copy link
Collaborator

lissyx commented Nov 16, 2021

Sorry, but it looks like there are failures, can you fix them?

@dudewheresmycode
Copy link
Author

@lissyx, sorry but the errors in the test failures might be a bit over my head. I'm not sure they're related directly to the electron version bump.

The windows failure seems to be the main TensorFlow lib for Windows being unable to compile properly.

ERROR: D:/a/deepspeech/deepspeech/tensorflow/tensorflow/core/platform/default/BUILD:177:1: C++ compilation of rule '//tensorflow/core/platform/default:logging' failed (Exit 1): vc_installation_error.bat failed: error executing command 
  cd D:/a/deepspeech/deepspeech/.bazel_cache/output/execroot/org_tensorflow

The linux failure seems to be at the check_artifact_exists step. I don't even see an error on that one, just seems to fail after downloading artifacts.

@lissyx, have you run the current master branch through GitHub Actions recently to make sure it's all still passing without these changes?

@lissyx
Copy link
Collaborator

lissyx commented Nov 17, 2021

@lissyx, sorry but the errors in the test failures might be a bit over my head. I'm not sure they're related directly to the electron version bump.

The windows failure seems to be the main TensorFlow lib for Windows being unable to compile properly.

ERROR: D:/a/deepspeech/deepspeech/tensorflow/tensorflow/core/platform/default/BUILD:177:1: C++ compilation of rule '//tensorflow/core/platform/default:logging' failed (Exit 1): vc_installation_error.bat failed: error executing command 
  cd D:/a/deepspeech/deepspeech/.bazel_cache/output/execroot/org_tensorflow

The linux failure seems to be at the check_artifact_exists step. I don't even see an error on that one, just seems to fail after downloading artifacts.

If windows is failing to build, check_artifact_exists might fail as a side effect

@lissyx, have you run the current master branch through GitHub Actions recently to make sure it's all still passing without these changes?

I am not working on this project anymore, so I advise to have a look at older PRs merged on https://github.com/mozilla/DeepSpeech/commits/master and see their status.

It's possible there has been GitHub Actions specific regressions, I'd suspect the Windows ones for example. But I really have no time to investigate and fix those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants