Do not include current extension in 'Other popular extensions' #22946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstinalin
requested review from
a team and
KevinMind
and removed request for
a team
KevinMind
reviewed
Jan 9, 2025
chrstinalin
force-pushed
the
#1569-other-extensions
branch
from
38c3d09 to
5fb7e68
Compare
chrstinalin
force-pushed
the
#1569-other-extensions
branch
from
be37e58 to
23b3e33
Compare
KevinMind
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#1569
Description
Filters out the current extension from 'other popular extensions' when using the fallback extensions.
Testing
TAAR_LITE_FALLBACKSuses GUIDs from production, so I'm actually unsure what the proper way of testing this should be. You can mimick the behaviour locally by replacing the GUIDs inTAAR_LITE_FALLBACKSwith local ones (similar to the screenshot)Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.