Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /deps/node_modules to /data/olympia/node_modules #22955

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

KevinMind
Copy link
Contributor

Fixes: mozilla/addons#ISSUENUM

Description

Context

Testing

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@KevinMind KevinMind force-pushed the vite branch 4 times, most recently from f8c9504 to 097b07d Compare December 22, 2024 20:39
@KevinMind KevinMind force-pushed the vite branch 9 times, most recently from b712f84 to 2cb6c62 Compare December 31, 2024 11:49
/deps/ -> /data/olympia/deps
/deps/node_modules -> /data/olympia/node_modules

This effectively maps the host path for dependencies into the container directly and also means npm just "works"
@KevinMind KevinMind force-pushed the vite branch 5 times, most recently from b886164 to ff6b5da Compare December 31, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant