Read Promoted Group Information Via Models #23082
Draft
+681
−426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstinalin
force-pushed
the
#15350-read-promoted-models
branch
3 times, most recently
from
ef58b87 to
d3fe342
Compare
diox
reviewed
Feb 27, 2025
Comment on lines
-1052
to
+1091
| with self.assertNumQueries(0): | ||
| result = self.serializer.to_representation(obj) | ||
| return result | ||
| return self.serializer.to_representation(obj) |
There was a problem hiding this comment.
I know this is just a draft & not finished yet, but FYI, the search & autocomplete APIs handle a lot of our traffic and should never execute any database queries. We shouldn't ship a change that would regress this assertNumQueries(0) assertion and the one below, they are important to keep.
diox
reviewed
Feb 27, 2025
Comment on lines
-7171
to
+7173
| with self.assertNumQueries(0): | ||
| response = self.client.get(url, data, **headers) | ||
| response = self.client.get(url, data, **headers) |
There was a problem hiding this comment.
As mentioned above, search should never execute database queries.
chrstinalin
force-pushed
the
#15350-read-promoted-models
branch
3 times, most recently
from
5f12b66 to
36ded4b
Compare
chrstinalin
force-pushed
the
#15350-read-promoted-models
branch
from
d497061 to
4928d11
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15350
Description
Reads promoted group information via models.
Context
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.