Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitor retry task and tests for Celery tasks #23092

Draft
wants to merge 12 commits into
base: graphviz
Choose a base branch
from
Draft

Add monitor retry task and tests for Celery tasks #23092

wants to merge 12 commits into from

Conversation

KevinMind
Copy link
Contributor

Fixes: mozilla/addons#ISSUENUM

Description

Introduces AMOMonitorRetryTask to support monitoring and retrying tasks with configurable delays. Adds test cases to verify monitor behavior and retry mechanisms.

Context

Enables defining monitors that a task should be dependent on and adds automatic retry for those monitors based on a constant interval.

Testing

  1. modify the cinder monitor so that it returns 'failure', True
  2. add @task(monitors=['cinder']) to one of the existing cinder tasks
  3. run the task in a djshell

Expect that the task is re-queued due to the cinder monitor failing. IF you revert step 1 it should pass the next time it runs.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

dependabot bot and others added 12 commits February 19, 2025 13:02
@dependabot
Bump pytest-django from 4.9.0 to 4.10.0 in /requirements (#23066)
1f3e27c 
Bumps [pytest-django](https://github.com/pytest-dev/pytest-django) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/pytest-dev/pytest-django/releases)
- [Changelog](https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst)
- [Commits](pytest-dev/pytest-django@v4.9.0...v4.10.0)

---
updated-dependencies:
- dependency-name: pytest-django
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump jsdom from 24.1.3 to 26.0.0 (#23048)
258dc84 
Bumps [jsdom](https://github.com/jsdom/jsdom) from 24.1.3 to 26.0.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@24.1.3...26.0.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump prompt-toolkit from 3.0.48 to 3.0.50 in /requirements (#23003)
9742edd 
Bumps [prompt-toolkit](https://github.com/prompt-toolkit/python-prompt-toolkit) from 3.0.48 to 3.0.50.
- [Release notes](https://github.com/prompt-toolkit/python-prompt-toolkit/releases)
- [Changelog](https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/CHANGELOG)
- [Commits](prompt-toolkit/python-prompt-toolkit@3.0.48...3.0.50)

---
updated-dependencies:
- dependency-name: prompt-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump cachetools from 5.5.0 to 5.5.1 in /requirements (#23008)
dc801d7 
Bumps [cachetools](https://github.com/tkem/cachetools) from 5.5.0 to 5.5.1.
- [Changelog](https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst)
- [Commits](tkem/cachetools@v5.5.0...v5.5.1)

---
updated-dependencies:
- dependency-name: cachetools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump ipython from 8.31.0 to 8.32.0 in /requirements (#23046)
071c797 
Bumps [ipython](https://github.com/ipython/ipython) from 8.31.0 to 8.32.0.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@8.31.0...8.32.0)

---
updated-dependencies:
- dependency-name: ipython
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump pytz from 2024.2 to 2025.1 in /requirements (#23042)
981d7ca 
Bumps [pytz](https://github.com/stub42/pytz) from 2024.2 to 2025.1.
- [Release notes](https://github.com/stub42/pytz/releases)
- [Commits](stub42/pytz@release_2024.2...release_2025.1)

---
updated-dependencies:
- dependency-name: pytz
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump deprecated from 1.2.15 to 1.2.18 in /requirements (#23029)
acd30f6 
Bumps [deprecated](https://github.com/laurent-laporte-pro/deprecated) from 1.2.15 to 1.2.18.
- [Release notes](https://github.com/laurent-laporte-pro/deprecated/releases)
- [Changelog](https://github.com/laurent-laporte-pro/deprecated/blob/master/CHANGELOG.rst)
- [Commits](laurent-laporte-pro/deprecated@v1.2.15...v1.2.18)

---
updated-dependencies:
- dependency-name: deprecated
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump certifi from 2024.12.14 to 2025.1.31 in /requirements (#23040)
1c838a5 
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.12.14 to 2025.1.31.
- [Commits](certifi/python-certifi@2024.12.14...2025.01.31)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump django from 4.2.18 to 4.2.19 in /requirements (#23056)
ad3a69a 
Bumps [django](https://github.com/django/django) from 4.2.18 to 4.2.19.
- [Commits](django/django@4.2.18...4.2.19)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@eviljeff
Expose target affected versions for decision on held review page (#23090
d02701b 
)
@wagnerand
Update local dev docker images for autograph, elasticsearch, memcached (
e1aa355 
#23086)
@KevinMind
Add monitor retry task and tests for Celery tasks
012f690 
Introduces AMOMonitorRetryTask to support monitoring and retrying tasks with configurable delays. Adds test cases to verify monitor behavior and retry mechanisms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinMind @eviljeff @wagnerand