WIP: Initialize nss explicitly #6596
Conversation
jo
force-pushed
the
explicit-nss-initialization
branch
11 times, most recently
from
e23748c to
6a74eca
Compare
jo
force-pushed
the
explicit-nss-initialization
branch
12 times, most recently
from
578d4e7 to
8b539bb
Compare
| // TODO: would be nice if we could write | ||
| // #[uniffi::export] | ||
| // pub use nss::ensure_initialized as ensure_nss_initialized; | ||
| // instead. | ||
| #[uniffi::export] | ||
| pub fn ensure_nss_initialized() { | ||
| ensure_initialized() | ||
| } | ||
|
|
There was a problem hiding this comment.
@bendk is there a way to do something like
#[uniffi::export]
pub use nss::ensure_initialized as ensure_nss_initialized;
or a way to avoid wrapping the function?
There was a problem hiding this comment.
There is https://mozilla.github.io/uniffi-rs/latest/proc_macro/functions.html#renaming-functions-methods-and-constructors, but I don't think that will actually work here :( So I don't think there is a good way, but it seems like a reasonable feature request!
There was a problem hiding this comment.
doesn't look like there's already an issue filed for this, will do that
There was a problem hiding this comment.
Thanks for filing that. IMO, we could extend the concept of "external types" to also support "external functions".
jo
force-pushed
the
explicit-nss-initialization
branch
3 times, most recently
from
8a4bea3 to
d6ef0ab
Compare
| // TODO: would be nice if we could write | ||
| // #[uniffi::export] | ||
| // pub use nss::ensure_initialized as ensure_nss_initialized; | ||
| // instead. | ||
| #[uniffi::export] | ||
| pub fn ensure_nss_initialized() { | ||
| ensure_initialized() | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for filing that. IMO, we could extend the concept of "external types" to also support "external functions".
BREAKING CHANGE: you now need to call `nss::ensure_initialized()` before any calls to NSS functions, including dependants like rc_crypto or jwcrypto.
jo
force-pushed
the
explicit-nss-initialization
branch
from
d6ef0ab to
b1cd271
Compare
Initialize NSS explicitly, rather than implicitly in NSS-using functions.
To have control over NSS initialization, it must be done explicitly. This pull request removes implicit initialization from the relevant methods and instead checks whether NSS has been initialized and throws an appropriate error if it has not.
Initialization can be done either directly via NSS.
BREAKING CHANGE:
you now need to call
nss::ensure_initialized()before any calls to functions which depend on NSS. Watch out forCryptoError(Error(NSS error: NSS has not been initialized)).Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.