Remove Convert

See #11943
mozilla · Nov 27, 2023 · 531f1a7 · 531f1a7
1 parent 1befb9c
commit 531f1a7
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 178 deletions.
diff --git a/bedrock/base/templates/base-protocol.html b/bedrock/base/templates/base-protocol.html
@@ -6,7 +6,7 @@
 
 <!doctype html>
 {# Note the "windows" class, without javascript platform-specific assets default to windows #}
-<html class="windows no-js" lang="{{ LANG|replace('en-US', 'en') }}" dir="{{ DIR }}" data-country-code="{{ country_code }}" data-latest-firefox="{{ latest_firefox_version }}" data-esr-versions="{{ esr_firefox_versions|join(' ') }}" {% if settings.GTM_CONTAINER_ID %}data-gtm-container-id="{{ settings.GTM_CONTAINER_ID }}"{% endif %} {% block gtm_page_id %}{% endblock %} {% if settings.STUB_ATTRIBUTION_RATE %}data-stub-attribution-rate="{{ settings.STUB_ATTRIBUTION_RATE }}"{% endif %} {% if settings.CONVERT_PROJECT_ID %}data-convert-project-id="{{ settings.CONVERT_PROJECT_ID }}"{% endif %} {% if settings.SENTRY_FRONTEND_DSN %}data-sentry-dsn="{{ settings.SENTRY_FRONTEND_DSN }}"{% endif %} {% block html_attrs %}{% endblock %}>
+<html class="windows no-js" lang="{{ LANG|replace('en-US', 'en') }}" dir="{{ DIR }}" data-country-code="{{ country_code }}" data-latest-firefox="{{ latest_firefox_version }}" data-esr-versions="{{ esr_firefox_versions|join(' ') }}" {% if settings.GTM_CONTAINER_ID %}data-gtm-container-id="{{ settings.GTM_CONTAINER_ID }}"{% endif %} {% block gtm_page_id %}{% endblock %} {% if settings.STUB_ATTRIBUTION_RATE %}data-stub-attribution-rate="{{ settings.STUB_ATTRIBUTION_RATE }}"{% endif %} {% if settings.SENTRY_FRONTEND_DSN %}data-sentry-dsn="{{ settings.SENTRY_FRONTEND_DSN }}"{% endif %} {% block html_attrs %}{% endblock %}>
   <head>
     <meta charset="utf-8">{# Note: Must be within first 512 bytes of page #}
 

diff --git a/bedrock/mozorg/redirects.py b/bedrock/mozorg/redirects.py
@@ -559,7 +559,7 @@ def decider(request, **kwargs):
     redirect(r"^/exp/firefox/?$", "firefox"),
     redirect(r"^/exp/firefox/new/?$", "firefox.new"),
     redirect(r"^/exp/firefox/accounts/?$", "firefox.accounts"),
-    redirect(r"^/exp/opt-out/?$", "privacy.convert-opt-out"),
+    redirect(r"^/exp/opt-out/?$", "privacy.websites"),
     # Issue 13211
     redirect(r"^/en/$", "/en-US/", permanent=True),
     # Issue 13554

diff --git a/bedrock/privacy/templates/privacy/convert-opt-out.html b/bedrock/privacy/templates/privacy/convert-opt-out.html
diff --git a/bedrock/privacy/urls.py b/bedrock/privacy/urls.py
@@ -20,7 +20,6 @@
     path("thunderbird/", views.thunderbird_notices, name="privacy.notices.thunderbird"),
     path("websites/", views.websites_notices, name="privacy.notices.websites"),
     page("websites/data-preferences/", "privacy/data-preferences.html", ftl_files=["privacy/data-preferences"]),
-    page("websites/convert-opt-out/", "privacy/convert-opt-out.html"),
     path("firefox-monitor/", views.firefox_monitor_notices, name="privacy.notices.firefox-monitor"),
     path("mdn-plus/", views.mdn_plus, name="privacy.notices.mdn-plus"),
     path("ad-targeting-guidelines/", views.ad_targeting_guidelines, name="privacy.notices.ad-targeting-guidelines"),

diff --git a/bedrock/settings/__init__.py b/bedrock/settings/__init__.py
@@ -179,9 +179,6 @@
         "www.googletagmanager.com",
         "www.google-analytics.com",
         "creativecommons.org",
-        "cdn-4.convertexperiments.com",
-        "logs.convertexperiments.com",
-        "images.ctfassets.net",
     ]
     _csp_script_src = [
         # TODO fix things so that we don't need this
@@ -194,17 +191,11 @@
         "tagmanager.google.com",
         "www.youtube.com",
         "s.ytimg.com",
-        "cdn-4.convertexperiments.com",
-        "app.convert.com",
-        "data.track.convertexperiments.com",
-        "1003350.track.convertexperiments.com",
-        "1003343.track.convertexperiments.com",
         "js.stripe.com",
     ]
     _csp_style_src = [
         # TODO fix things so that we don't need this
         "'unsafe-inline'",
-        "app.convert.com",
     ]
     _csp_child_src = [
         "www.googletagmanager.com",
@@ -221,9 +212,6 @@
         "www.googletagmanager.com",
         "www.google-analytics.com",
         "region1.google-analytics.com",
-        "logs.convertexperiments.com",
-        "1003350.metrics.convertexperiments.com",
-        "1003343.metrics.convertexperiments.com",
         "sentry.prod.mozaws.net",  # DEPRECATED. TODO: remove this once all sites are talking to sentry.io instead
         "o1069899.sentry.io",
         "o1069899.ingest.sentry.io",

diff --git a/bedrock/settings/base.py b/bedrock/settings/base.py
@@ -1218,9 +1218,6 @@ def before_send(event, hint):
 #
 # where "103" in the variable name is the funnelcake ID.
 
-# Issue 7508 - Convert.com experiment sandbox
-CONVERT_PROJECT_ID = "10039-1003350" if DEV else "10039-1003343"
-
 # VPN ==========================================================================================
 
 # URL for Mozilla VPN sign-in links

diff --git a/docs/abtest.rst b/docs/abtest.rst
@@ -8,70 +8,6 @@
 A/B Testing
 ===========
 
-Convert experiments
--------------------
-
-Conversion rate optimization (CRO) experiments on bedrock can be run using a
-third-party tool called `Convert <https://convert.com>`_. Convert experiments
-are for relatively simple multivariate experiments, such as testing changes
-to headlines, images, or button copy.
-
-The Convert script is not included in part of bedrock's base bundle for
-performance reasons. To use Convert on a page, you can load the script
-behind a feature flag, which can be turned on / off for only the duration
-of an experiment. The script should be loaded inside the ``experiments``
-block in your template:
-
-.. code-block:: jinja
-
-    {% block experiments %}
-        {% if switch('experiment-convert-page-name', ['en-US']) %}
-            {{ js_bundle('convert') }}
-        {% endif %}
-    {% endblock %}
-
-Convert A/B tests can be implemented using the `Convert dashboard
-<https://convert.com>`_ and editor. Convert experiments should be coded and
-tested against staging, before being reviewed and scheduled to run in
-production.
-
-QA for Convert experiments
-~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-The process for QA'ing Convert experiments is as follows:
-
-#. Bedrock feature switch should be activated on staging.
-#. Experiment is built and configured to run on ``https://www.allizom.org/*``
-#. In the Github issue for an experiment, someone will request review by an engineer.
-
-An engineer reviewing the experiment will:
-
-#. Verify that the experiment is not configured to run on https://www.mozilla.org/ (production) yet.
-#. Activate the experiment to run on stage.
-
-During review, the engineer will compare the following to the experiment plan:
-
-#. The experiment’s logic.
-#. Any JS included (in Convert editor’s JS field).
-#. Any CSS included (in Convert editor’s CSS field).
-#. The target audience is configured.
-#. The goals are configured.
-#. The distribution percentages are configured.
-#. The target URLs are configured.
-
-Once the engineer is satisfied, the engineer (or someone else with write privileges) will:
-
-#. Add ``https://www.mozilla.org/*`` to the list of URLs the experiment can run on.
-#. Reset the experiment (eliminating any data gathered during QA).
-#. Enable the bedrock feature switch in production.
-#. Activate (or schedule) the experiment.
-
-After an experiment is finished, the feature switch should be deactivated in production.
-
-.. Note::
-
-    ``*`` should be replaced by the exact URL pathname for the experiment page.
-
 Traffic Cop experiments
 -----------------------
 

diff --git a/media/js/base/convert-snippet.js b/media/js/base/convert-snippet.js
diff --git a/media/static-bundles.json b/media/static-bundles.json
@@ -1832,12 +1832,6 @@
       ],
       "name": "annual_report_modal"
     },
-    {
-      "files": [
-        "js/base/convert-snippet.js"
-      ],
-      "name": "convert"
-    },
     {
       "files": [
         "js/libs/modernizr.custom.inputtypes.js",