Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Firefox feature pages [fix #11144] #13119

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

craigcook
Copy link
Member

@craigcook craigcook commented May 10, 2023

One-line summary

Updates Firefox feature pages. Some are rewrites of prior pages, some are brand new, some are reskins of existing pages, and some have been removed entirely.

The original plan was to preserve the old pages as fallbacks and only show the new ones for completed locales, at least for a while. But along the way that idea become untenable because so many are new or total rewrites, and several old pages were so outdated they weren't worth preserving. So this is a clean sweep and fresh start.

Significant changes and points to review

Lots of new strings and some string removal so that stuff needs some careful attention (I'll also ask Peiying for a review when she has time).

Issue / Bugzilla link

#11144

Testing

https://www-demo2.allizom.org/en-US/firefox/features/

http://localhost:8000/firefox/features/

@craigcook
Copy link
Member Author

craigcook commented May 10, 2023

To do:

  • Image for "Is Firefox a fast browser?"
  • Image for "Is Firefox a private browser?"
  • Image for the footer CTA (shown to non-Firefox)
  • Add/update Pontoon configs
  • Add/update tests

@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 9 times, most recently from 78a0d24 to 7485950 Compare May 15, 2023 14:44
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 3 times, most recently from f77833c to 86fe115 Compare May 24, 2023 00:12
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 2 times, most recently from 9387025 to 06094e9 Compare June 9, 2023 23:18
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch from 06094e9 to e2ec02b Compare July 11, 2023 17:16
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 2 times, most recently from ea5926a to 5afc805 Compare July 26, 2023 23:06
@craigcook craigcook added Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour and removed Do Not Merge ⚠️ labels Jul 26, 2023
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch from 5afc805 to facada6 Compare July 27, 2023 01:04
@craigcook craigcook marked this pull request as ready for review July 27, 2023 01:04
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch from facada6 to f0b1d7e Compare July 27, 2023 05:25
@craigcook
Copy link
Member Author

Some test failures, marking do-not-merge until I can sort that out.

@craigcook
Copy link
Member Author

The integration test failures seem unrelated and may just be a timeout on the test runner (it keeps failing on redirect tests, but not on any redirects I added/changed, and fails on different ones each time...). So removing the DNM tag and this is ready for review... but with caution. In a worst case, once it merges we'll see if tests pass on dev and if not, we can fix it there and/or revert the merge and dig deeper.

@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch from f0b1d7e to 03ed317 Compare July 27, 2023 17:11
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 5 times, most recently from d51d34d to 46f2827 Compare August 4, 2023 17:59
@craigcook
Copy link
Member Author

Successful test run(!): https://github.com/mozilla/bedrock/actions/runs/5765257018

@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 2 times, most recently from c439805 to 0575c1e Compare August 7, 2023 16:25
@reemhamz reemhamz self-assigned this Aug 8, 2023
@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 2 times, most recently from ed3bbb4 to 2036be0 Compare August 15, 2023 21:06
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a wild PR. Good job on getting it through the door! 🎉

Main thing that is (potentially) blocking would be the updated strings in adblocker.ftl file. Check with Peiying if they're going to be deleting strings from their end before we implement this change. If not, then let's update the names of the FTL variables.

Some other notable comments I have are just surrounding visible a11y, where image borders would be nice to add for screenshots + changing body text to black to make it more readable.

@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 2 times, most recently from 2c56bfc to 8a2ab03 Compare August 16, 2023 20:31
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. However, how come some of the new FTL files have -2023 in their name? I think those would be fine to remove?
r+w(possible)c 🎉

@craigcook
Copy link
Member Author

craigcook commented Aug 17, 2023

This looks good to me. However, how come some of the new FTL files have -2023 in their name? I think those would be fine to remove?

The dated files are ones that already existed but were completely rewritten, so it seemed better to delete the old file and add a brand new one rather than replace every string in an existing file. Some others have been translated but just have a few new strings and we don't want to throw out those translations so I kept the filenames. And still others are brand new pages so maybe those Fluent files should also be dated, just to be consistent.

@craigcook craigcook force-pushed the 11144-firefox-feature-pages branch 2 times, most recently from cd51c48 to e682852 Compare August 17, 2023 15:02
@reemhamz reemhamz added Do Not Merge ⚠️ and removed Needs Review Awaiting code review labels Aug 18, 2023
@reemhamz
Copy link
Contributor

Currently in code-freeze for all-hands. Code freeze lifts August 28th.

@craigcook craigcook merged commit fcee4e1 into mozilla:main Aug 28, 2023
6 checks passed
@craigcook craigcook deleted the 11144-firefox-feature-pages branch August 28, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants