-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Monitor product name #13729
Update Monitor product name #13729
Conversation
c488d31
to
005a95d
Compare
16cff9e
to
0e1ff79
Compare
0e1ff79
to
09ee94b
Compare
09ee94b
to
6b6ff6d
Compare
Note: I haven't updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we're going to be asked to do all this work for Relay too. I think it would be worth while to bundle it so we're not sending v3 versions of strings for translation only to have v4s in 2 weeks. I've asked Emma to look into it.
6b6ff6d
to
d5a5799
Compare
@stephaniehobson thanks, updated. Ideally, I'd like these strings to get out to localizers soon so we have plenty of time for locales to update. Bunching up translation work makes sense, but I also don't want this to get held up behind a product decision that has yet to be made? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luke says there's no plans to change soon.
R+
One-line summary
Updates strings and product word-marks for Monitor behind
SWITCH_MOZILLA_MONITOR_BRAND_NAME
Significant changes and points to review
Did I miss anything?
Note:
Issue / Bugzilla link
N/A
Testing