Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Monitor product name #13729

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Sep 28, 2023

@alexgibson alexgibson added P1 First level priority - Must have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Sep 28, 2023
@alexgibson alexgibson marked this pull request as ready for review September 28, 2023 11:48
@alexgibson alexgibson force-pushed the monitor-name-change branch 2 times, most recently from 16cff9e to 0e1ff79 Compare September 28, 2023 12:00
@alexgibson alexgibson marked this pull request as draft September 28, 2023 12:24
@alexgibson alexgibson marked this pull request as ready for review September 28, 2023 12:49
@alexgibson
Copy link
Member Author

Note: I haven't updated /welcome/3/ here, as that page is now being removed in #13733

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we're going to be asked to do all this work for Relay too. I think it would be worth while to bundle it so we're not sending v3 versions of strings for translation only to have v4s in 2 weeks. I've asked Emma to look into it.

l10n/en/firefox/browsers/compare/chrome.ftl Outdated Show resolved Hide resolved
@alexgibson
Copy link
Member Author

@stephaniehobson thanks, updated.

Ideally, I'd like these strings to get out to localizers soon so we have plenty of time for locales to update. Bunching up translation work makes sense, but I also don't want this to get held up behind a product decision that has yet to be made? Thanks

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luke says there's no plans to change soon.

R+

@stephaniehobson stephaniehobson merged commit 4566ec5 into mozilla:main Oct 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P1 First level priority - Must have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants