Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove performance.html references #14049

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

reemhamz
Copy link
Contributor

@reemhamz reemhamz commented Jan 5, 2024

One-line summary

Removed references to the now obsolete performance.html file

Significant changes and points to review

A string update was requested for a Firefox Developer page, which was done here: #14021, however since references to the for-developer.html template (that had the updated string) were being conditionally added to several files with the ftl_has_messages helper with the conditions of the now-obsolete strings being available, I removed the ftl helper and also removed the older performance.html template that was under the else option, which was isn't even being rendered anymore because the conditional logic was placed years ago, and relevant strings had already been translated.

Issue / Bugzilla link

This is an extra ticket to finish off #13970

Testing

@reemhamz reemhamz added Needs Review Awaiting code review Review: XS Code review time: up to 30min Frontend HTML, CSS, JS... client side stuff labels Jan 5, 2024
@stephaniehobson stephaniehobson self-assigned this Jan 5, 2024
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ ⏩

@stephaniehobson stephaniehobson merged commit 3d5b11b into mozilla:main Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants