-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy page simplification #14688
Privacy page simplification #14688
Conversation
8a5789c
to
dbd4a33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very through clean up. I love seeing all the code being removed 🧹
A couple quick changes and this'll be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also functional tests associated:
bedrock/tests/functional/firefox/privacy/test_products.py
Lines 7 to 14 in ddcf11c
from pages.firefox.privacy.products import FirefoxPrivacyProductsPage | |
@pytest.mark.smoke | |
@pytest.mark.skip_if_firefox(reason="Download buttons are shown to non-Firefox browsers only") | |
@pytest.mark.nondestructive | |
def test_download_button_displayed(base_url, selenium): | |
page = FirefoxPrivacyProductsPage(selenium, base_url).open() |
that ought to be removed with the page gone now.
Besides that only a couple of further cleanup ideas:
5f71d26
to
172f9bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14688 +/- ##
==========================================
- Coverage 77.17% 77.16% -0.01%
==========================================
Files 159 159
Lines 8245 8246 +1
==========================================
Hits 6363 6363
- Misses 1882 1883 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jan Brasna <[email protected]>
One-line summary
I used an AI to write some of this code.Significant changes and points to review
Issue / Bugzilla link
#14248
Testing
http://localhost:8000/en-US/firefox/privacy/