Ensure Docker builds include any CSS needed when the CMS Admin mode is active, too #14756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhudson
approved these changes
Jun 28, 2024
pmac
approved these changes
Jun 28, 2024
…s active, too To test this, I did `make build prod` to build a new release image, locally, then shelled in: $ pwd /app $ ls static/admin/css autocomplete.4a81fc4242d0.css dark_mode.ef27a31af300.css nav_sidebar.269a1bd44627.css rtl.css autocomplete.css dashboard.css nav_sidebar.css vendor base.523eb49842a7.css dashboard.e90f2068217b.css responsive.css widgets.css base.css forms.c14e1cb06392.css responsive.f6533dab034d.css widgets.ee33ab26c7c2.css changelists.9237a1ac391b.css forms.css responsive_rtl.7d1130848605.css changelists.css login.586129c60a93.css responsive_rtl.css dark_mode.css login.css rtl.512d4b53fc59.css I also compared this with a release image made yesterday, before this change: $ pwd /app $ ls static/admin/ ls: cannot access 'static/admin/': No such file or directory
stevejalim
force-pushed
the
14752-ensure-admin-statics-get-collected-during-docker-build
branch
from
5a93640
to
9918505
Compare
stevejalim
deleted the
14752-ensure-admin-statics-get-collected-during-docker-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
To test this, I did
make build prodto build a new release image, locally, then shelled in:I also compared this with a release image made yesterday, before this change:
Issue / Bugzilla link
Resolves #14752 - Django Admin and RQ list fail up in CMS mode on Dev deployment