Drop superfluous CSP (+report object-src) #14897
Open
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
Needs Review
janbrasna
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14897 +/- ##
==========================================
- Coverage 77.34% 77.33% -0.01%
==========================================
Files 161 161
Lines 8348 8349 +1
==========================================
Hits 6457 6457
- Misses 1891 1892 +1 ☔ View full report in Codecov by Sentry. |
janbrasna
commented
Jul 29, 2024
| @@ -269,6 +265,7 @@ | |||
| CONTENT_SECURITY_POLICY_REPORT_ONLY["DIRECTIVES"]["report-uri"] = csp_report_uri | |||
| # CSP directive updates we're testing that we hope to move to the enforced policy. | |||
| CONTENT_SECURITY_POLICY_REPORT_ONLY["DIRECTIVES"]["frame-ancestors"] = [csp.constants.NONE] | |||
| CONTENT_SECURITY_POLICY_REPORT_ONLY["DIRECTIVES"]["object-src"] = [csp.constants.NONE] | |||
There was a problem hiding this comment.
I'm also a little tempted to test-drive restricting default-src to just self? (Instead of all the default wildcards)
Suggested change
| CONTENT_SECURITY_POLICY_REPORT_ONLY["DIRECTIVES"]["object-src"] = [csp.constants.NONE] | |
| CONTENT_SECURITY_POLICY_REPORT_ONLY["DIRECTIVES"]["object-src"] = [csp.constants.NONE] | |
| CONTENT_SECURITY_POLICY_REPORT_ONLY["DIRECTIVES"]["default-src"] = [csp.constants.SELF] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Removes hosts already covered by defaults/wildcards appended to every policy.
Significant changes and points to review
(This will be redone anyways for #11943 when every policy gets its own subset of hosts, instead of appending the default wildcards everywhere…)
Also adds
object-src: noneto report-only for helping out surface any hypothetical use.Issue / Bugzilla link
#14896 (+#11943)
Testing
curl -I http://localhost:8000/de/