Remove fixed Fluent linter brand exclusions #14996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
commented
Aug 23, 2024
Comment on lines
27
to
28
| - "{ -brand-name-mozilla } account" | ||
| exclusions: |
There was a problem hiding this comment.
Hmh I'm actually thinking about adding "MDN" as another brand to check, seems all is passing at the moment: janbrasna@c16e494✅
There was a problem hiding this comment.
Nah, an "MDN" literal string sneaked in with 3e34323 and already hit pontoon so it's too late for adding that here.
stephaniehobson
added
Needs Review
janbrasna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
The remaining linter exception was removed from strings when translations changed last year.
Issue / Bugzilla link
Removed in #13644
Testing
✅ actions/runs/10517645057/job/29142138942?pr=14996#step:5:1