Refresh: Update copy & add images #15143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
added
Refresh 🦖
stephaniehobson
force-pushed
the
m24-images
branch
2 times, most recently
from
cbb4ecc
to
6ee7f8c
Compare
stephaniehobson
added
Needs Review
make logos bigger
stephaniehobson
force-pushed
the
m24-images
branch
from
6ee7f8c
to
482eea3
Compare
reemhamz
requested changes
Sep 18, 2024
| </div> | ||
| <p class="m24-consider-cta-info">Interested in advocacy? Love coding? Join our best-in-class talent and let’s transform the web, for everyone.</p> | ||
| <p class="m24-consider-cta-info">Join our team and push the boundaries of what's possible — without compromising on what matters.</p> |
There was a problem hiding this comment.
Nit
Suggested change
| <p class="m24-consider-cta-info">Join our team and push the boundaries of what's possible — without compromising on what matters.</p> | |
| <p class="m24-consider-cta-info">Join our team and push the boundaries of what’s possible — without compromising on what matters.</p> |
Comment on lines
+9
to
+14
| <h1 class="m24-c-copy-title m24-t-2xl">Reclaim the internet with us</h1> | ||
| <p>Mozilla is an activist organization working to put control of the internet back in the hands of the people using it.</p> | ||
| <p><strong>We advocate</strong> for better products, holding governments and tech corporations accountable for what they create. We monitor developments, conduct research, and campaign to improve products and drive policies that will represent your interests.</p> | ||
| <p><strong>We build</strong> products that put you in control. Like Firefox, Fakespot and more.</p> | ||
| <p><strong>We fund</strong> and invest in the people and efforts taking technology, the internet, and AI in the right direction.</p> | ||
| <p>Together, we can keep the internet easy, safe and free, for everyone.</p> |
There was a problem hiding this comment.
Suggestion: I feel as if, by way of design, this section should be list items wrapped within an ul element?
Also, the body text here (and in similar sections) looks pretty bold in comparison to the Figma design? Because of that, the bolded words in the beginning of each point (that are wrapped in <strong> don't stand out very much?
Comment on lines
+20
to
+23
| "img/mozorg/about/2024/about-hero.png": "1424w", | ||
| "img/mozorg/about/2024/about-hero-high-res.png": "2848w", | ||
| "img/mozorg/about/2024/about-hero-2-1.png": "375w", | ||
| "img/mozorg/about/2024/about-hero-2-1-high-res.png": "750w", |
There was a problem hiding this comment.
The design is showing a different image?
| "height": "299", | ||
| } | ||
| ), | ||
| desc='Next steps for Mozilla and Trustworthy AI', |
There was a problem hiding this comment.
Nit: I think this should be a title
| "height": "448", | ||
| } | ||
| ), | ||
| desc='At the Rise25 Awards, the future of AI is ethical, inclusive and accountable', |
There was a problem hiding this comment.
Nit: Same here, should be a title
| cta_text='Visit', | ||
| ) }} | ||
|
|
||
| {{ grid_tile( | ||
| class='m24-l-grid-third', | ||
| image=resp_img( | ||
| url="img/m24/todo-1-1.svg", | ||
| url="img/m24/common-voice.png", |
There was a problem hiding this comment.
Suggested change
| url="img/m24/common-voice.png", | |
| url="img/home/2024/cards/common-voice.png", |
| image=resp_img( | ||
| url="img/m24/todo-5-4.svg", | ||
| url="img/m24/builders.png", |
There was a problem hiding this comment.
Suggested change
| url="img/m24/builders.png", | |
| url="img/home/2024/cards/builders.png", |
| image=resp_img( | ||
| url="img/m24/todo-5-7.svg", | ||
| url="img/m24/ventures.png", |
There was a problem hiding this comment.
Suggested change
| url="img/m24/ventures.png", | |
| url="img/home/2024/cards/ventures.png", |
There was a problem hiding this comment.
Test out this section to check if the CTAs work in this section after the fix I commented above
| </div> | ||
| <p class="m24-c-showcase-info">Sed eu mattis</p> | ||
| <p class="m24-c-showcase-cta"><a href="https://rise25.mozilla.org/" class="m24-c-cta" data-cta-text="">Learn more</a></p> | ||
| <!-- <p class="m24-c-showcase-info">Sed eu mattis</p> --> |
There was a problem hiding this comment.
Question: Is this good to delete?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Update copy & add images
Significant changes and points to review
The copy and images are probably all out of date since I did this on Friday. Let's merge anyway because it's not going to L10n and if I did a new export they'd probably all change again anyway. Having content (even if it is stale) will make QA easier.
Issue / Bugzilla link
#14892
#14893
Testing