Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation functional tests #15153

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Sep 16, 2024

One-line summary

Points navigation tests to the old nav for now, since #14966 merged.

Issue / Bugzilla link

N/A

Testing

Successful test run: https://github.com/mozilla/bedrock/actions/runs/10881946899

@alexgibson alexgibson added P2 Second level priority - Should have Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Sep 16, 2024
@alexgibson alexgibson marked this pull request as ready for review September 16, 2024 10:37
Copy link
Collaborator

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

I assume once the new design reaches de we'll need to update these further, yeah?

@alexgibson
Copy link
Member Author

I assume once the new design reaches de we'll need to update these further, yeah?

Yeah, at that stage we need to write new tests for the redesigned components

@alexgibson alexgibson merged commit 8840a2a into mozilla:main Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P2 Second level priority - Should have Review: µ Code review time: 5 minutes or less
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants