Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to not output on page #15170

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor to not output on page #15170

wants to merge 1 commit into from

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Sep 17, 2024 •
edited
Loading

One-line summary

This cuts down on (but does not totally prevent) the CSS variables being defined several times on a page.

Significant changes and points to review

  • I moved the CSS variable definitions into their own file so it can be included once on any page using the new styles

Issue / Bugzilla link

Testing

This is still a draft because:

  • There's an outstanding to-do for the colour themes.

@stephaniehobson stephaniehobson force-pushed the m24-refactor branch 2 times, most recently from ed0f3c8 to 7f5593e Compare September 17, 2024 19:00
@stephaniehobson stephaniehobson added Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh labels Sep 19, 2024
@janbrasna janbrasna mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stephaniehobson