-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix navigation tap issue #15154 #15173
Conversation
eec7c19
to
3f9deea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15173 +/- ##
==========================================
+ Coverage 77.83% 77.88% +0.05%
==========================================
Files 162 163 +1
Lines 8459 8480 +21
==========================================
+ Hits 6584 6605 +21
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice, elegant solution that does not require JS 👏
3f9deea
to
1a79734
Compare
1a79734
to
c00a27f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ nice work!
One-line summary
Significant changes and points to review
Issue / Bugzilla link
#15154
Testing