Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix navigation tap issue #15154 #15173

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

wen-2018
Copy link
Collaborator

One-line summary

Significant changes and points to review

Issue / Bugzilla link

#15154

Testing

@wen-2018 wen-2018 changed the title fix issue #15154 fix navigation tap issue #15154 Sep 17, 2024
@wen-2018 wen-2018 added Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh labels Sep 18, 2024
@wen-2018 wen-2018 marked this pull request as ready for review September 18, 2024 12:57
@wen-2018 wen-2018 added the Needs Review Awaiting code review label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (1940447) to head (c00a27f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15173      +/-   ##
==========================================
+ Coverage   77.83%   77.88%   +0.05%     
==========================================
  Files         162      163       +1     
  Lines        8459     8480      +21     
==========================================
+ Hits         6584     6605      +21     
  Misses       1875     1875              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice, elegant solution that does not require JS 👏

media/css/m24/components/navigation-refresh.scss Outdated Show resolved Hide resolved
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ nice work!

@alexgibson alexgibson merged commit bb03d17 into mozilla:main Sep 19, 2024
5 checks passed
@wen-2018 wen-2018 removed the Needs Review Awaiting code review label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants