Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style hr transition in base-navigation-and-footer #15194

Closed
wants to merge 1 commit into from
Closed

Style hr transition in base-navigation-and-footer #15194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions media/css/m24/base-navigation-and-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
@import 'vars/text';

// global components
@import 'transition';
@import 'components/footer-refresh';
Comment on lines +17 to 18
Copy link
Contributor Author

@janbrasna janbrasna Sep 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmh while working this produces not so nice results for some pages that end with colour shapes, like:

Screenshot 2024-09-22 at 17 43 03

(barely visible, but it's there…)

Screenshot 2024-09-22 at 19 10 42

or better:

Screenshot 2024-09-22 at 19 10 59

and

Screenshot 2024-09-22 at 17 45 17

or

Screenshot 2024-09-22 at 19 24 32

Hiding the hr for now with low specificity .m24-c-transition * { display: none; } (that's only effective until the proper declaration is loaded) looks perhaps better — but that doesn't solve the issue once 2024 styles are turned on site-wide — when that divider gets styled globally and places with somewhat rectangular blocks ending the pages will display like this anyway…

@import 'components/navigation-refresh';