Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fx News one-click-subscribe page (Fixes #15142) #15197

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Sep 20, 2024

One-line summary

Adds one-click confirmation landing page for Firefox newsletter

Issue / Bugzilla link

#15142

Testing

First get your newsletter token by following these steps:

  1. Open https://www.mozilla.org/en-US/newsletter/recovery/ and enter your email.
  2. Find the recovery email, and click the link that opens the email preference center.
  3. Open Dev Tools -> Storage -> Cookies and find the cookie called nl-token. Copy it's value (which should be a long alpha-numeric string).
  4. Whilst you're here, make sure you are not subscribed to the Firefox newsletter (unsubscribe if you are).

Next, open the confirmation page using your token in the URL:

  1. Open: http://localhost:8000/en-US/newsletter/firefox/confirm/{INSERT_YOUR_TOKEN_HERE}
  2. When the page loads, click "Confirm".
  3. Wait to see a "thank you" message and then you should now be subscribed to Firefox news.
  4. Finally, confirm the subscription has worked by going back to the newsletter management page, and you should hopefully see Firefox News is checked in the list.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (82453fe) to head (a91e3c1).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
bedrock/newsletter/views.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15197      +/-   ##
==========================================
- Coverage   78.36%   78.33%   -0.03%     
==========================================
  Files         157      157              
  Lines        8181     8185       +4     
==========================================
+ Hits         6411     6412       +1     
- Misses       1770     1773       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgibson alexgibson force-pushed the fx-news-one-click branch 2 times, most recently from 290bed4 to 8827647 Compare September 25, 2024 09:12
@alexgibson alexgibson added Do Not Merge ⚠️ P2 Second level priority - Should have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Sep 30, 2024
@alexgibson alexgibson marked this pull request as ready for review September 30, 2024 09:18
@alexgibson
Copy link
Member Author

This is ready for code review, but marking as do-not-merge pending approval of final copy.

@alexgibson
Copy link
Member Author

OK, this is finally approved and good to merge once it's been reviewed.

@alexgibson alexgibson force-pushed the fx-news-one-click branch 2 times, most recently from c2625dc to 0a33f1b Compare October 15, 2024 09:04
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📫

@craigcook craigcook merged commit d29d782 into mozilla:main Oct 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P2 Second level priority - Should have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants