Moments page for Root Certification expiration (1 of 6) #15212
Conversation
reemhamz
added
WIP 🚧
reemhamz
force-pushed
the
moments-root-one
branch
from
f9b8247
to
02900da
Compare
reemhamz
changed the title
reemhamz
added
Needs Review
There was a problem hiding this comment.
attn: welcome/16 and /18 both reference the file, so better not remove that from those…
(i have a wip in my backlog to clean these welcome xrefs between versions where possible, and also dedupe the assets if they're already somewhere more canonical… so i'll tackle that at some point later separately.)
There was a problem hiding this comment.
Those pages are mentioning page../firefox-wordmark-light.svg, not this particular file path?
There was a problem hiding this comment.
At one point this image was moved here from page16 assets so I figured it would be missing there:
Now that 16–18 are updated too to link the canonical location instead it should be all hunky-dory. (Just wanted to point out it touches more welcome pages' both light and dark appearances so to make sure they're also included in testing they still render as expected…)
There was a problem hiding this comment.
d'oh, i forgot that i moved it, i thought I just pasted it! I was looking for that file during this fix 😅 thanks for pointing it out to me. I also just went ahead and used the global image you pointed out in a previous comment to replace all these individual page-specific assets, so it'll be more uniform going forward :)
There was a problem hiding this comment.
🙏 Praise! Thanks, lovely. 💟 Those assets linked between page versions that have nothing common are always in risk being inadvertently removed breaking something unrelated (here, here, me, me…) so this was def on my backlog to make more universal, thanks for taking care of it going few versions back (and getting the correct dimensions! I know the local assets were not the exact right size all the time…)
(Also: nice svgo cleanup job on all the remaining assets! 🚀)
reemhamz
force-pushed
the
moments-root-one
branch
from
4885059
to
b712b9b
Compare
There was a problem hiding this comment.
This all looks good to me, nice work! r+ but it sounds like they want to review on a demo server before we merge? Though I'm not sure what needs review, we can't really make copy changes since it's all translated already... but we can merge as soon as we get signoff.
|
Can do -- I'll set up demos now :) ! |
|
Sound like you can ignore my comment above, they’re just gonna rely on Firefox version update metrics instead 👍 |
One-line summary
Moments page made for letting users know to update their Firefox browsers so they aren't affected by the Root Certification expiration.
This is 1 of 6 moments pages to be developed for the Root Certification info. More to come in a few months
📆 Launch date: October 9th 2024 📆
Note
This is hard-coded in 15 languages, enjoy the review! 😅
Issue / Bugzilla link
#15162
Testing
Localhost
Demo servers