-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newsletter form to nothing-personal page (Fixes #15218) #15223
Conversation
41dc5bc
to
5833e1e
Compare
This is ready for code review, but marking as do-not-merge for now until we get sign-off that things are ready. |
5833e1e
to
a38f761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, works great. r+
I'll leave this for you to merge when you get the final go-ahead 👍🏼
a38f761
to
79d1542
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15223 +/- ##
=======================================
Coverage 77.88% 77.89%
=======================================
Files 163 163
Lines 8480 8483 +3
=======================================
+ Hits 6605 6608 +3
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, but it took a moment to wrap my head around it. Maybe some comment or tweaking a var name would help our future selves?
r+wc
79d1542
to
7e40838
Compare
One-line summary
Adds a newsletter form to the bottom of
/firefox/nothing-personal/
.Issue / Bugzilla link
#15218
Testing
http://localhost:8000/en-US/firefox/nothing-personal/