Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Mozilla advertising pages [fix #15198] #15228

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

craigcook
Copy link
Member

One-line summary

Updates the /advertising page, now a set of pages with more detailed info on specific products. This is meant to go live by 2 October 2024

Issue / Bugzilla link

#15198

Testing

http://localhost:8000/advertising/
http://localhost:8000/advertising/formats/
http://localhost:8000/advertising/principles/

@craigcook craigcook added Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour Do Not Merge ⚠️ labels Sep 30, 2024
@craigcook
Copy link
Member Author

Marking Do Not Merge because I'm waiting for an updated hero image for the main page, but it should be ready for code review otherwise.

@craigcook
Copy link
Member Author

craigcook commented Sep 30, 2024

There's a test failure in the newsletter form which seems unrelated to anything in this PR, not sure what's up with that. Fixed

@craigcook
Copy link
Member Author

craigcook commented Sep 30, 2024

Marking Do Not Merge because I'm waiting for an updated hero image for the main page, but it should be ready for code review otherwise.

The image has been updated, this can merge once it passes code review.

@reemhamz reemhamz self-assigned this Oct 1, 2024
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big PR, and you did a very good job with it!
I left some suggestions and fixes that should be quick to patch up.
I'll approve this for now since it needs to go out soon, so feel free to merge after you work on the changes. r+wc

bedrock/mozorg/templates/mozorg/advertising/landing.html Outdated Show resolved Hide resolved
bedrock/mozorg/templates/mozorg/advertising/landing.html Outdated Show resolved Hide resolved
bedrock/mozorg/templates/mozorg/advertising/formats.html Outdated Show resolved Hide resolved
bedrock/mozorg/templates/mozorg/advertising/formats.html Outdated Show resolved Hide resolved
media/img/mozorg/advertising/principle-safe.svg Outdated Show resolved Hide resolved
@reemhamz reemhamz removed the Needs Review Awaiting code review label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (2df9c9b) to head (f2eb8af).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15228   +/-   ##
=======================================
  Coverage   77.88%   77.88%           
=======================================
  Files         163      163           
  Lines        8480     8480           
=======================================
  Hits         6605     6605           
  Misses       1875     1875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@craigcook craigcook merged commit a09093f into mozilla:main Oct 1, 2024
6 checks passed
@craigcook craigcook deleted the 15198-ads-pages branch October 1, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants