Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add our fork of wagtaildraftsharing to Bedrock #15232

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

stevejalim
Copy link
Collaborator

@stevejalim stevejalim commented Oct 1, 2024

This branch was originally a test harness for using mozmeao/wagtaildraftsharing#1 in bedrock, but now it's just adding in the completed work from that PR.

In order to test drive this branch (using the steps outlined for reviewing that PR liked above), you need to carry out these steps:

  1. Check out this branch by running git fetch on whatever your mozilla origin is called, then git switch 15181--wagtail-page-review-without-auth.
  2. make install-local-python-deps to get requirements installed - check that our fork of wagtaildraftsharing is being installed
  3. ./manage.py migrate
  4. Start your runserver as usual and then go to Add Wagtail 6 support + extra way to create a sharing link mozmeao/wagtaildraftsharing#1 to continue testing

Related Issues

Resolves #15181

@stevejalim stevejalim force-pushed the 15181--wagtail-page-review-without-auth branch from d732997 to d8556dc Compare October 9, 2024 18:59
@stevejalim stevejalim marked this pull request as ready for review October 9, 2024 19:00
@stevejalim stevejalim requested a review from pmac October 9, 2024 19:00
@stevejalim stevejalim changed the title WIP strapping in a WIP version of wagtaildraftsharing Add our fork of wagtaildraftsharing to Bedrock Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (847aeae) to head (d8556dc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15232   +/-   ##
=======================================
  Coverage   78.35%   78.36%           
=======================================
  Files         162      162           
  Lines        8316     8318    +2     
=======================================
+ Hits         6516     6518    +2     
  Misses       1800     1800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pmac pmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📜

@stevejalim stevejalim merged commit 572c25e into main Oct 10, 2024
5 checks passed
@stevejalim stevejalim deleted the 15181--wagtail-page-review-without-auth branch October 10, 2024 09:08
@stevejalim
Copy link
Collaborator Author

@alexgibson FYI draftsharing work is now landing in mozilla/bedrock:main - thanks for the review of the library over on mozmeao/wagtaildraftsharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support any _permitted_ person to preview content in the CMS before go-live
2 participants