Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase navigation logo lockup size (Fixes #15477) #15491

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

alexgibson
Copy link
Member

One-line summary

Adjusts the navigation logo size for both desktop and mobile. Also improves focus ring alignment.

Issue / Bugzilla link

#15477

Testing

Enable switch M24_WEBSITE_REFRESH

http://localhost:8000/en-US/

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less Refresh 🦖 Work related to the 2024 site refresh labels Nov 13, 2024
@maureenlholland maureenlholland self-assigned this Nov 13, 2024
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny typo issue, optional padding adjustment

media/css/m24/components/navigation-refresh.scss Outdated Show resolved Hide resolved
media/css/m24/components/navigation-refresh.scss Outdated Show resolved Hide resolved
@alexgibson
Copy link
Member Author

@maureenlholland great suggestions, updated!

Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 r+

@maureenlholland maureenlholland merged commit 848d459 into mozilla:main Nov 14, 2024
5 checks passed
@alexgibson alexgibson deleted the nav-logo branch November 14, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P3 Third level priority - Nice to have Refresh 🦖 Work related to the 2024 site refresh Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants