Migrate /careers to use Sass @use (Issue #10896) #15821
Conversation
alexgibson
added
P3
| @@ -43,11 +41,11 @@ $image-path: '/media/protocol/img'; | |||
| } | |||
|
|
|||
| &.c-careers-instagram { | |||
| background-image: url('#{$image-path}/icons/social/instagram/black.svg'); | |||
| background-image: url('/media/protocol/img/icons/social/instagram/black.svg'); | |||
There was a problem hiding this comment.
question (non-blocking): any particular reason to replace with the string?
This line from styles.scss gave me the impression that variable would be set wherever it was later imported (since the file is only supposed to load once, it would apply config from the initial import... but it's been a while since I tested that)
@use '~@mozilla-protocol/core/protocol/css/includes/lib' as * with ($image-path: '/media/protocol/img');
There was a problem hiding this comment.
Good question! It seemed a bit unnecessary here, since the $image-path variable is mostly used for protocol components, where we import the styles but still need to dynamically change the image paths. It seemed a bit neater to use a simple string here, since the third icon uses a different hard-coded path too.
One-line summary
Removes use of
@importfrom careers pages .scss files.Issue / Bugzilla link
#10896
Testing
http://localhost:8000/en-US/careers/