Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make footer readable and functional for IE 11 (fix #15536) #15827

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Jan 8, 2025

One-line summary

This PR makes the new footer readable and functional for IE 11.

Significant changes and points to review

This is what it looks like now in IE 11, Window 10

ie-footer

RTL

rtl

Issue / Bugzilla link

#15536

Testing

  • Using Broswerstack to test in IE 11, Window 10
  • The footer should change at all in newer modern browsers

@wen-2018 wen-2018 requested a review from a team as a code owner January 8, 2025 18:04
@wen-2018 wen-2018 added Needs Review Awaiting code review Frontend HTML, CSS, JS... client side stuff labels Jan 8, 2025
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - simple but effective improvements! r+wc

media/css/m24/components/footer-refresh.scss Outdated Show resolved Hide resolved
@alexgibson alexgibson removed the Needs Review Awaiting code review label Jan 9, 2025
@wen-2018 wen-2018 merged commit 4be9180 into mozilla:main Jan 9, 2025
3 checks passed
@wen-2018 wen-2018 deleted the footer-ie-improvement branch January 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants