Skip to content

Commit

Permalink
Unmark reading feature flags as deprecated
Browse files Browse the repository at this point in the history
Nimbus doesn't provide a proper replacement yet, as we can't have
multiple experiments affecting the same user, rollouts aren't
immediate, and we can't allowlist specific users, so reading
feature flags is fine for now.

I don't think we'll need to write new code to modify the flags (we
have the admin UI for that already), so I'm leaving those marked
as deprecated.
  • Loading branch information
Vinnl committed Jul 24, 2024
1 parent 00482d9 commit ec1abbe
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/db/tables/featureFlags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export async function getDeletedFeatureFlags() {
.returning("*");
}

/** @deprecated The method type not be used */
export type FeatureFlagName =
| "RedesignedEmails"
| "UpdatedEmailPreferencesOption"
Expand All @@ -56,7 +55,6 @@ export type FeatureFlagName =

/**
* @param options
* @deprecated The method should not be used, use Nimbus experiment or roll-out: /src/app/functions/server/getExperiments
*/
export async function getEnabledFeatureFlags(
options:
Expand Down

0 comments on commit ec1abbe

Please sign in to comment.