Remove dynamic NEXT_PUBLIC_* environment variables #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
commented
Nov 10, 2023
| @@ -105,7 +105,7 @@ export const UserMenu = (props: UserMenuProps) => { | |||
| > | |||
| <a | |||
| className={styles.menuItemCta} | |||
| href={process.env.NEXT_PUBLIC_EXTERNAL_SUPPORT_URL} | |||
| href={process.env.NEXT_PUBLIC_MONITOR_SUPPORT_URL} | |||
There was a problem hiding this comment.
This ensures it uses the value from
Line 150 in d1a7ce6
I've submitted a PR to remove the other version from the stage and prod machines.
It's fine to use NEXT_PUBLIC_* environment variables that are defined in `.env-dist` and are the same in every environment. However, since they are inserted at build time, they cannot be dynamically inserted at runtime, and trying to do so will instead inject the value they have at build time.
Vinnl
force-pushed
the
MNTOR-2434-no_NEXT_PUBLIC
branch
from
d1a7ce6 to
20ff0b1
Compare
mansaj
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-2434 and MNTOR-2145
Figma: N/A
Description
It's fine to use NEXT_PUBLIC_* environment variables that are defined in
.env-distand are the same in every environment. However, since they are inserted at build time, they cannot be dynamically inserted at runtime, and trying to do so will instead inject the value they have at build time.I'll also submit a PR to remove those values from the prod env.