Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Monthly Monitor report to *Plus report #4984

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Aug 26, 2024

References:

Jira: MNTOR-3512
Figma: N/A

Description

Also, since that setting only applies to Plus users, moved the string to the non-localised strings. (The previous string might come back in a future feature, but as I understand it, Pontoon will remember it for easy re-translation.)

Screenshot (if applicable)

image

How to test

Visit the Settings page with a Plus account.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - N/A, string change
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Aug 26, 2024
@Vinnl Vinnl requested review from codemist and flozia August 26, 2024 14:34
@Vinnl Vinnl self-assigned this Aug 26, 2024
@Vinnl Vinnl requested a review from flodolo as a code owner August 26, 2024 14:34
Also, since that setting only applies to Plus users, moved the
string to the non-localised strings. (The previous string might
come back in a future feature, but as I understand it, Pontoon will
remember it for easy re-translation.)
@Vinnl Vinnl force-pushed the MNTOR-3512-monthly-plus-report branch from 77e44b8 to cec91ea Compare August 26, 2024 14:39
Copy link

@Vinnl Vinnl merged commit d8f6ff4 into main Aug 27, 2024
15 checks passed
@Vinnl Vinnl deleted the MNTOR-3512-monthly-plus-report branch August 27, 2024 11:48
Copy link

Cleanup completed - database 'blurts-server-pr-4984' destroyed, cloud run service 'blurts-server-pr-4984' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants