Unsubscription from monthly report confirmation page #4998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-4998-mgjlpikfea-uk.a.run.app |
6 tasks
codemist
force-pushed
the
unsubscribe-email-confirmation-fe
branch
from
4fe81c5 to
3d6d35e
Compare
codemist
commented
Sep 3, 2024
Comment on lines
+33
to
+45
| const handleUnsubscription = async () => { | ||
| try { | ||
| const response = await fetch(`/api/unsubscribe?token=${token}`, { | ||
| method: "GET", | ||
| }); | ||
|
|
||
| if (response.ok) { | ||
| setUnsubscribeSuccess(true); | ||
| } | ||
| } catch (e) { | ||
| console.error("Error during unsubscription:", e); | ||
| } | ||
| }; |
There was a problem hiding this comment.
@Vinnl Do you know how to retrieve the users' email without having to query it from the URL?
There was a problem hiding this comment.
I was hoping that wouldn't be necessary - see #4988 (comment).
|
Cleanup completed - database 'blurts-server-pr-4998' destroyed, cloud run service 'blurts-server-pr-4998' destroyed |
codemist
added a commit
that referenced
this pull request
Sep 5, 2024
* fix: gurantee boolean value * fix: update should upsert too * fix: delete primary_email field * fix: remove dup primary_email from new table * fix: generate the link for the unsub page instead * feat: some example code for FE * extract data from the right table * Unsubscription from monthly report confirmation page * pass in the right function * fix unit tests * fix unit tests --------- Co-authored-by: Joey Zhou <[email protected]>
codemist
added a commit
that referenced
this pull request
Sep 5, 2024
* fix: gurantee boolean value * fix: update should upsert too * fix: delete primary_email field * fix: remove dup primary_email from new table * fix: generate the link for the unsub page instead * feat: some example code for FE * extract data from the right table * Unsubscription from monthly report confirmation page * pass in the right function * fix unit tests * fix unit tests --------- Co-authored-by: Joey Zhou <[email protected]>
codemist
added a commit
that referenced
this pull request
Sep 12, 2024
* fix: gurantee boolean value * fix: update should upsert too * fix: delete primary_email field * fix: remove dup primary_email from new table * fix: generate the link for the unsub page instead * feat: some example code for FE * extract data from the right table * Unsubscription from monthly report confirmation page * pass in the right function * fix unit tests * fix unit tests --------- Co-authored-by: Joey Zhou <[email protected]>
codemist
added a commit
that referenced
this pull request
Sep 13, 2024
* feat: some example code for FE * extract data from the right table * Unsubscription from monthly report confirmation page (#4998) * fix: gurantee boolean value * fix: update should upsert too * fix: delete primary_email field * fix: remove dup primary_email from new table * fix: generate the link for the unsub page instead * feat: some example code for FE * extract data from the right table * Unsubscription from monthly report confirmation page * pass in the right function * fix unit tests * fix unit tests --------- Co-authored-by: Joey Zhou <[email protected]> * pass subscriber data * return void * add toast * correct api endpoint * remove debugging comments * add try again link * add feature flag * rename file * override css variables * wrap in try catch * add loader * fixup * add toat if catch error * remove original css override styles * move to /unsubscribe-email folder * lint * add try again styling * use plus language for header * unit test --------- Co-authored-by: Kaitlyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3556
Figma:https://www.figma.com/design/CaEKIhvSJqf6KNIMzSkt40/Concepts-for-Monitor-MVP-Redesign?node-id=2298-89690&node-type=FRAME&t=nkcj8ZpN91IIOPgD-0
Description
Screenshot (if applicable)
preview at http://localhost:6060/unsubscribe-from-monthly-report
Not applicable.
How to test
Checklist (Definition of Done)