Add landing page experiment #5434
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/app/(proper_react)/(redesign)/(public)/LandingViewRedesign.test.tsx
Dismissed
Show dismissed
Hide dismissed
src/app/(proper_react)/(redesign)/(public)/LandingViewRedesign.test.tsx
Dismissed
Show dismissed
Hide dismissed
src/app/(proper_react)/(redesign)/(public)/LandingViewRedesign.test.tsx
Dismissed
Show dismissed
Hide dismissed
|
Preview URL 🚀 : https://blurts-server-pr-5434-mgjlpikfea-uk.a.run.app |
| @@ -101,6 +101,33 @@ features: | |||
| value: { "enabled": true } | |||
| - channel: production | |||
| value: { "enabled": true } | |||
| landing-page-redesign: | |||
| description: Landing page redesign | |||
There was a problem hiding this comment.
I wonder if this might be confusing later, could we give it a more unique name? Do we ever remove these?
There was a problem hiding this comment.
Good point — I’ve updated the experiment ID to be a bit more explicit in bd0974e.
@rhelmer This PR is only adding the new landing page redesign page together with the |
| <LandingViewRedesign | ||
| eligibleForPremium={eligibleForPremium} | ||
| l10n={getL10n()} | ||
| countryCode={countryCode} | ||
| scanLimitReached={scanLimitReached} | ||
| experimentData={experimentData["Features"]} | ||
| /> | ||
| ) : ( | ||
| <LandingView | ||
| eligibleForPremium={eligibleForPremium} | ||
| l10n={getL10n()} | ||
| countryCode={countryCode} | ||
| scanLimitReached={scanLimitReached} | ||
| experimentData={experimentData["Features"]} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
Are these two meant to be the same?
There was a problem hiding this comment.
One is the new LandingViewRedesign layout and the other is the current LandingView — both are taking the same props.
|
Cleanup completed - database 'blurts-server-pr-5434' destroyed, cloud run service 'blurts-server-pr-5434' destroyed |
References:
Jira:
Description
Adds the new view for the landing page experiment
landing-page-redesigntogether with the feature flagLandingPageRedesign. The content of the page will be implemented together with MNTOR-3806.How to test
Enable the feature flag
LandingPageRedesignand visit/.Checklist (Definition of Done)