Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor landing page adjustments #5560

Merged
merged 8 commits into from
Jan 30, 2025
Merged

Minor landing page adjustments #5560

merged 8 commits into from
Jan 30, 2025

Conversation

flozia
Copy link
Collaborator

@flozia flozia commented Jan 29, 2025 •
edited by jira bot
Loading

References:

Jira:

Figma: https://www.figma.com/design/xa533LXIOuK6KG6vXGyysr/Landing-pages?node-id=399-41089&t=kLUkcgLH38bfyFnn-4

Description

Minor layout changes and fixes for the landing page experiment.

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.

@flozia flozia requested a review from flodolo as a code owner January 29, 2025 15:09
@flozia flozia requested review from Vinnl and codemist January 29, 2025 15:09
@flozia flozia self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5560-mgjlpikfea-uk.a.run.app

Vinnl
Vinnl approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only perused the code, but nothing jumped out there.

@flozia flozia merged commit 7befad8 into main Jan 30, 2025
16 checks passed
@flozia flozia deleted the landing-page-qa branch January 30, 2025 13:10
@github-actions GitHub Actions
Copy link

Cleanup completed - database 'blurts-server-pr-5560' destroyed, cloud run service 'blurts-server-pr-5560' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

@Vinnl Vinnl Vinnl approved these changes

@codemist codemist Awaiting requested review from codemist

Assignees

@flozia flozia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flozia @Vinnl @flodolo