Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt at skipping unstable Node versions #5564

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Jan 30, 2025

#5558 didn't do it either. I think this matches the Ruby version syntax? There's so little info about it online (or I don't know how to search for Ruby docs).

I wish projects just didn't use regular version numbers for unstable releases.

I think this matches the Ruby version syntax? There's so little
info about it online (or I don't know how to search for Ruby docs).
@Vinnl Vinnl added the Review: µ Code review time: 5 minutes or less label Jan 30, 2025
@Vinnl Vinnl requested a review from rhelmer January 30, 2025 13:52
@Vinnl Vinnl self-assigned this Jan 30, 2025
Copy link

@rhelmer
Copy link
Collaborator

rhelmer commented Jan 30, 2025

@Vinnl I don't know if it will help here, but one thing I do on other PRs to test github action changes is to temporarily allow my PR branch to trigger the automation. However I don't know if this applies for dependabot

@Vinnl
Copy link
Collaborator Author

Vinnl commented Jan 30, 2025

Yeah that works for CI changes, but Dependabot I think looks at the default branch. If this was a personal repository I'd change it, but I don't want to risk that here :)

@Vinnl Vinnl merged commit 0d0406e into main Jan 30, 2025
16 checks passed
@Vinnl Vinnl deleted the dependabot-version-final-v2-final-for-real-this-time branch January 30, 2025 15:35
Copy link

Cleanup completed - database 'blurts-server-pr-5564' destroyed, cloud run service 'blurts-server-pr-5564' destroyed

@Vinnl
Copy link
Collaborator Author

Vinnl commented Jan 30, 2025

Woohoo! Now to see if it will submit a PR for the minor version upgrade...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants