MNTOR-3953 - Add monthly report free email state for expired sub #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5668-mgjlpikfea-uk.a.run.app |
flozia
reviewed
Feb 27, 2025
| // If a free scan is run, show auto-removed exposures (should be 0, unless a user has an expired sub with previously removed exposures) | ||
| dataPointValue: hasRunFreeScan | ||
| ? props.dataSummary.dataBrokerAutoFixedDataPointsNum | ||
| : 1, |
There was a problem hiding this comment.
Question: Is showing the auto-removed exposures as 1 when no scan has been run correct here: Wouldn’t there be no exposures that could have been removed?
There was a problem hiding this comment.
Ah, I see: In this scenario, without a used free scan we don’t show the auto-removed exposures here, but the number of available scans.
flozia
approved these changes
Feb 27, 2025
| // If a free scan is run, show auto-removed exposures (should be 0, unless a user has an expired sub with previously removed exposures) | ||
| dataPointValue: hasRunFreeScan | ||
| ? props.dataSummary.dataBrokerAutoFixedDataPointsNum | ||
| : 1, |
There was a problem hiding this comment.
Ah, I see: In this scenario, without a used free scan we don’t show the auto-removed exposures here, but the number of available scans.
|
Cleanup completed - database 'blurts-server-pr-5668' destroyed, cloud run service 'blurts-server-pr-5668' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3953
Figma:
Description
The "auto-removed" table should not be 0 if a user had previously auto-removed data exposures but then downgraded to a free account.
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)