Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ..Default::default() for struct Config #911

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jschwe
Copy link
Contributor

@jschwe jschwe commented Dec 27, 2023

Previously the depfile option added a new private member to the Config struct - a breaking change which many users complained about. Making the field public, but hiding it from the documentation and excluding it from serde reverts the breakage, while keeping the depfile functionality.

I also considered adding an InternalConfig struct, but this would require breaking changes to at least Config::from_file() and Config::from_root_or_default(), which is a lot more invasive than my PR.

Closes #908

Previously the `depfile` option added a new private member to the
`Config` struct - a breaking change which many users complained about.
Making the field public, but hiding it from the documentation and
excluding it from `serde` reverts the breakage, while keeping the
depfile functionality.
@jschwe
Copy link
Contributor Author

jschwe commented Feb 6, 2024

@emilio Any chance you could find some time to review this patch?

Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah, thanks for the ping, and sorry, I haven't been able to dedicate a lot of time to cbindgen recently.

@emilio emilio merged commit c9c90bf into mozilla:master Feb 6, 2024
2 checks passed
@jschwe jschwe deleted the pub_config branch February 6, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config (still) has private fields in 0.26
2 participants