Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpplint warnings #946

Closed
wants to merge 4 commits into from
Closed

Fix cpplint warnings #946

wants to merge 4 commits into from

Conversation

vanillajonathan
Copy link
Contributor

Closes #865

emilio
emilio requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but you need to update the tests too. cargo test should just do it.

@emilio
Copy link
Collaborator

emilio commented Apr 15, 2024

It seems tests were still somewhat unhappy, but I updated them manually and merged this in ca78140. Thanks!

@emilio emilio closed this Apr 15, 2024
@emilio
Copy link
Collaborator

emilio commented Apr 15, 2024

(I think if you were running git on windows, your autoclrf settings were probably messing up a couple of the tests)

@vanillajonathan vanillajonathan deleted the patch-2 branch April 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpplint warnings: two spaces between code and comments
2 participants
@vanillajonathan @emilio