Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix report_only to REPORT_ONLY in decorator docs #224

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix report_only to REPORT_ONLY in decorator docs #224

merged 1 commit into from
Jun 7, 2024

Conversation

robhudson
Copy link
Member

No description provided.

@robhudson robhudson requested a review from stevejalim June 6, 2024 23:33
stevejalim
stevejalim approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

I can see how this got missed as a non-snake-case function param is unusual.

@stevejalim stevejalim merged commit 193c0f5 into mozilla:main Jun 7, 2024
9 checks passed
@robhudson
Copy link
Member Author

Yeah. The reason it's all caps is to match the REPORT_ONLY config in the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejalim stevejalim stevejalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robhudson @stevejalim