Expand the ruff config to include import sorting and others. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Thanks @robhudson! I like it when the robots point out issues, and love it when they can make the changes too.
| @@ -85,13 +85,59 @@ include-package-data = true | |||
| [tool.setuptools.packages] | |||
| find = { namespaces = false } | |||
|
|
|||
| [tool.ruff] | |||
There was a problem hiding this comment.
👍 I'm glad to see us merging to pyproject.toml!
| @@ -45,9 +47,9 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def migrate_settings() -> Tuple[Dict[str, Any], bool]: | |||
| def migrate_settings() -> tuple[dict[str, Any], bool]: | |||
There was a problem hiding this comment.
It's interesting that this is allowed with Python 3.8 with from __future__ import annotations
| @@ -18,7 +20,7 @@ def _unquote(s: str) -> str: | |||
|
|
|||
|
|
|||
| @register.tag(name="script") | |||
| def script(parser: Parser, token: Token) -> "NonceScriptNode": | |||
| def script(parser: Parser, token: Token) -> NonceScriptNode: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.