This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Bug 1010444 Participants opt out of public list #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're failing Travis right now, so probably just need to run |
| isPrivate: isPrivate | ||
| }, function () { | ||
| $scope.$emit('privateChange'); | ||
| }, privateFail); |
There was a problem hiding this comment.
This function can go inline since you're only calling it once. I'd also suggest naming the inlined callbacks for clarity and easier readability.
IE: function success () {}, function fail () {}
gvn
added a commit
that referenced
this pull request
Jul 21, 2014
Bug 1010444 Participants opt out of public list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.