Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Microsurveys docs #620

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

Amejia481
Copy link
Contributor

Description (optional)

This add Android documentation for microsurveys

@Amejia481
Copy link
Contributor Author

👋🏽
Hi @jeddai, @jaredlockhart and @shell1,

Could you help me to find a reviewing for this PR.

Thanks in advance!

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for writing this up and sharing @Amejia481. Curious why not add it in the Deep Dives section similar to where our mobile surveys info lie? Or should that have been under this section? Not too familiar with the organization of the docs here.

https://experimenter.info/mobile-surveys

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doc can apply to both, do you think it'll be better to follow our other docs in which it splits iOS and Android:
https://experimenter.info/mobile-behavioral-targeting/#instrumented-events
or is two separate ones preferred for you?

Copy link
Contributor

@t-p-white t-p-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Amejia481 🙌 added a few comments

@Amejia481
Copy link
Contributor Author

Amejia481 commented Jul 31, 2024

this doc can apply to both, do you think it'll be better to follow our other docs in which it splits iOS and Android: https://experimenter.info/mobile-behavioral-targeting/#instrumented-events or is two separate ones preferred for you?

I guess it depends on how different are the implementations, if they are close enough we could use the same document and only have code sections for Android and iOS, but If they defer a lot, I think it could be easier for the reader to have two docs, we can land this as a starting point, and you could update it as you think it fits :)

@Amejia481
Copy link
Contributor Author

Thanks for all your feedback, really appreciate it. I think we could land this and update as it fit while create the iOS version, as @cyndichin will have more context of which approach to use when compering, iOS vs Android implementation.

@Amejia481 Amejia481 requested review from t-p-white and cyndichin July 31, 2024 16:59
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Amejia481!~ Looks good, I'll start my docs this week and tag you when that PR is up!

@Amejia481
Copy link
Contributor Author

@shell1 when you have some availability could you, merge this PR, thanks in advance!

@Amejia481
Copy link
Contributor Author

cc @jaredlockhart

@brennie brennie merged commit affc0a7 into mozilla:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants