Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nimbus): Show preview recipe json #12122

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(nimbus): Show preview recipe json #12122

wants to merge 2 commits into from
+32 −5

Conversation

yashikakhurana
Copy link
Contributor

Because

  • We want to have a link on the summary page to preview recipe json easily

This commit

  • Adds a link on the sidebar to preview recipe json

Fixes #12112
Screenshot 2025-01-29 at 10 26 27 AM

@yashikakhurana
Copy link
Contributor Author

@jaredlockhart all done

Screen.Recording.2025-01-30.at.7.12.59.PM.mov

@yashikakhurana yashikakhurana mentioned this pull request Feb 4, 2025
Open
jaredlockhart
jaredlockhart requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking/working great 🎉 🎉 🎉

I did find one edge case:

  1. Be on any page
  2. Click 'Show Preview Json' link
  3. Navigates to detail page and expands json
  4. Click 'Show/Hide JSON' to hide json
  5. Scroll back up
  6. Click 'Show Preview Json' link

Expected: Scrolls back down to JSON and expands

Actual: Scrolls back back down but doesn't expand

That could be confusing for users, looks like the JS is triggering once on page load but not on subsequent clicks. See if you can modify it to work on all subsequent clicks, maybe attach a click handler in addition to the page load behaviour you have now?

Otherwise looking great 💯 💯 💯 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart requested changes

@brennie brennie Awaiting requested review from brennie brennie is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar preview recipe json link
2 participants
@yashikakhurana @jaredlockhart