feat(nimbus): Show preview recipe json #12122
Open
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashikakhurana
requested review from
jaredlockhart and
brennie
as code owners
jaredlockhart
previously requested changes
Jan 29, 2025
experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/sidebar.html
Outdated
Show resolved
Hide resolved
|
@jaredlockhart all done Screen.Recording.2025-01-30.at.7.12.59.PM.mov |
jaredlockhart
requested changes
Feb 5, 2025
There was a problem hiding this comment.
This is looking/working great 🎉 🎉 🎉
I did find one edge case:
- Be on any page
- Click 'Show Preview Json' link
- Navigates to detail page and expands json
- Click 'Show/Hide JSON' to hide json
- Scroll back up
- Click 'Show Preview Json' link
Expected: Scrolls back down to JSON and expands
Actual: Scrolls back back down but doesn't expand
That could be confusing for users, looks like the JS is triggering once on page load but not on subsequent clicks. See if you can modify it to work on all subsequent clicks, maybe attach a click handler in addition to the page load behaviour you have now?
Otherwise looking great 💯 💯 💯 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #12112
