Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third party lib clarification #1918

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Third party lib clarification #1918

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79daf8d
Add relevant policy text to the page
dotproto Jul 19, 2024
dd15bc3
Add standard styling for blockquotes
dotproto Jul 19, 2024
760a9f1
Apply suggestions from code review
dotproto Jul 22, 2024
50f35d9
Revert changes made to the policies page
dotproto Jul 22, 2024
8c80dc9
Revise intro and Q&A for clarity
dotproto Jul 30, 2024
363f994
Update src/content/documentation/publish/third-party-library-usage.md
dotproto Aug 2, 2024
6fe59bf
Revert style changes
dotproto Aug 1, 2024
f293dad
Update src/content/documentation/publish/third-party-library-usage.md
dotproto Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/assets/css/_settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ $defnlist-margin-bottom: 1rem;
$defnlist-term-weight: $global-weight-bold;
$defnlist-term-margin-bottom: 0.3rem;
$blockquote-color: $dark-gray;
$blockquote-padding: rem-calc(15 0);
$blockquote-border: 0;
$blockquote-padding: rem-calc(16 0 16 16);
$blockquote-border: 5px solid #aaa;
$cite-font-size: rem-calc(13);
$cite-color: $black;
$cite-pseudo-content: '';
Expand Down
10 changes: 3 additions & 7 deletions src/content/documentation/develop/known-issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,9 @@ This page contains a list of significant known issues that affect the experience

**Description:** While debugging an extension on Android, you may encounter an error in Firefox on your desktop that says something like:

<blockquote style="padding-left: 1rem; border-left: 5px solid #aaa;">

Cannot connect to the debug target. See error details below:<br><br>

`Error: Protocol error (Error): Attempted to write a response containing a destroyed actor from: root (resource://devtools/shared/protocol/types.js:358:17)`

</blockquote>
> Cannot connect to the debug target. See error details below:
>
> `Error: Protocol error (Error): Attempted to write a response containing a destroyed actor from: root (resource://devtools/shared/protocol/types.js:358:17)`
dotproto marked this conversation as resolved.
Show resolved Hide resolved

**Workaround:** In the `about:debugging` page on your development computer, disconnect from and reconnect to the Android device.

Expand Down
3 changes: 1 addition & 2 deletions src/content/documentation/publish/add-on-policies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,14 @@ In general, developers are free to maintain their add-ons in the manner they cho

The following requirements are of particular importance:


- Add-ons must only request those permissions that are necessary for them to function.
- Add-ons must be self-contained and not load remote code for execution.
- Add-ons must not load or redirect to a remote new tab page. The new tab page must be contained within the add-on.
- Add-ons must not relax web page security headers, such as the Content Security Policy.
- Add-ons must use encryption when transporting data remotely.
- Add-ons should avoid including redundant code or files.
- Add-ons must not negatively impact the performance or stability of Firefox.
- Only release versions of third-party libraries and/or frameworks may be included with an add-on. Modifications to these libraries/frameworks are not permitted. Please read our [third party library guidelines](/documentation/publish/third-party-library-usage/) to better understand related requirements.
- Only release versions of third-party libraries and/or frameworks may be included with an add-on. Modifications to these libraries/frameworks are not permitted. Please read our [third party library guidelines](/documentation/publish/third-party-library-usage/) to better understand related requirements. {% comment %}Changes to this line should also be copied to /src/content/documentation/publish/third-party-library-usage.md{% endcomment %}
dotproto marked this conversation as resolved.
Show resolved Hide resolved

{% endcapture %}
{% include modules/one-column.liquid,
Expand Down
6 changes: 5 additions & 1 deletion src/content/documentation/publish/third-party-library-usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ date: 2022-10-17

# Third Party Library Usage

To complete the review process at [addons.mozilla.org](https://addons.mozilla.org) (AMO), reviewers must be able to verify the code in your extension. You may include third-party libraries in your extension. In that case, when you upload your extension to AMO, you will need to provide links to the library source code.
> Only release versions of third-party libraries and/or frameworks may be included with an add-on. Modifications to these libraries/frameworks are not permitted.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Only release versions of third-party libraries and/or frameworks may be included with an add-on. Modifications to these libraries/frameworks are not permitted.
> Only release versions of third-party libraries and frameworks can be included in an add-on. Modifications to included libraries and frameworks are not permitted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating the sentence, can we link to the policies section like:

Please note the requirements for third-party libraries in the #Add-on Policies#, where #Add-on Policieslinks to the development section of the policies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll update the PR to integrate this feedback after I merge @rebloor's other feedback.

>
> [Development Practices](/documentation/publish/add-on-policies/#development-practices), [Add-ons Policies](/documentation/publish/add-on-policies/)
dotproto marked this conversation as resolved.
Show resolved Hide resolved

To complete the review process at [addons.mozilla.org](https://addons.mozilla.org) (AMO), reviewers must be able to verify the code in your extension. If you include third-party libraries in your extension, you will need to provide links to the library source code as part of the AMO submission process.
dotproto marked this conversation as resolved.
Show resolved Hide resolved

If your add-on uses minified, obfuscated or otherwise machine-generated first-party code, please see [our requirements](/documentation/publish/source-code-submission/) for that.

Expand Down
Loading