Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to django-csp 4.0 #4800

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Update to django-csp 4.0 #4800

merged 5 commits into from
Jun 24, 2024

Conversation

jwhitlock
Copy link
Member

This release is in beta, but we can be an early adopter to help work out the bugs.

How to test

  • Install the requirements
  • Run ./manage.py check, no issues reported
  • Push to Heroku Dev, go to API docs, look for CSP errors in console.

privaterelay/types.py Outdated Show resolved Hide resolved
privaterelay/settings.py Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@jwhitlock
Copy link
Member Author

@groovecoder We may want to wait for #4796, since that also changes the CSP rules. Or get those changes into this PR as well.

@groovecoder
Copy link
Member

@groovecoder We may want to wait for #4796, since that also changes the CSP rules. Or get those changes into this PR as well.

Either way is fine. The CSP changes in #4796 will be easy to change to this new syntax.

"connect-src": [
SELF,
"https://www.google-analytics.com/",
"https://www.googletagmanager.com/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: thanks!

@groovecoder groovecoder added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 394faf7 Jun 24, 2024
29 checks passed
@groovecoder groovecoder deleted the django-csp-4.0 branch June 24, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants