Work around bug that was breaking q.empty() #1634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peter-wangxu/persist-queue#154 can cause
q.empty()
to return inaccurate results, which in turn can cause the flush manager to incorrectly think that disks were flushed because this loop wouldn't drain the queue:gcp-ingestion/ingestion-edge/ingestion_edge/flush.py
Line 134 in 70b8960