Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android NDK & SDK to the latest releases #2903

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Android NDK & SDK to the latest releases #2903

wants to merge 2 commits into from

Conversation

rvandermeulen
Copy link
Contributor

No description provided.

@rvandermeulen
Copy link
Contributor Author

@badboy Do you have idea what the issue is with CircleCI? The Taskcluster-based Android build/tests works and the lints all pass locally for me. Looks like some kind of environment setup issue.

@rvandermeulen
Copy link
Contributor Author

Ugh, looks like it's a known issue that's fixed in newer AGPs.
https://issuetracker.google.com/issues/294137077

@chutten chutten marked this pull request as ready for review February 21, 2025 18:57
@chutten chutten requested a review from a team as a code owner February 21, 2025 18:57
@chutten chutten requested review from badboy and removed request for a team February 21, 2025 18:57
@chutten
Copy link
Contributor

chutten commented Feb 21, 2025

According to the issue tracker, should be good now? But it'll need a rebase.

@chutten
Copy link
Contributor

chutten commented Feb 21, 2025

(and I guess m-c's on 27.2.12479018 now)

@chutten chutten requested review from chutten and removed request for badboy February 21, 2025 19:04
@rvandermeulen
Copy link
Contributor Author

The NDK could probably be bumped any time, but the SDK bump is still blocked on updating AGP in #2680. Happy to update this PR once that's done, though!

@chutten
Copy link
Contributor

chutten commented Feb 21, 2025

Yeah, okay, that looks arcane enough that I should leave it until Jan-Erik gets back. Deep magic out there.

I will note in case it helps that merely updating ndkVersion in build.gradle was enough to allow me to build the Glean SDK on the command line with m-c's bootstrapped ndk, sdk, and java. (with the appropriate envvars and local.properties)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutten chutten Awaiting requested review from chutten

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvandermeulen @chutten