Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci rerun-skip] certificate-transparency: use legacy id for tls timing #737

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

betling
Copy link
Contributor

@betling betling commented Jan 14, 2025

changed tls timing data source to use legacy client id in experiment toml file. also removed division in metric 'from' statement since that is what worked in our test query.

@betling betling requested a review from mikewilli January 14, 2025 18:00
Copy link
Collaborator

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are fine to leave the microseconds to seconds conversion, but LGTM thanks!

jetstream/certificate-transparency.toml Outdated Show resolved Hide resolved
@betling betling added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 7f80285 Jan 14, 2025
6 checks passed
@betling betling deleted the cert-transparency-legacy-id branch January 14, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants