Clippy tests #122
Clippy tests #122
Conversation
Not sure how this can be done from the command-line, but VS Code brings all these up.
| if client { | ||
| hconn = Http3Connection::new(default_client(), 100, 100, None); | ||
| neqo_trans_conn = default_server(); | ||
| let (mut hconn, mut neqo_trans_conn) = if client { |
There was a problem hiding this comment.
I don't like how clippy warns about this one. But I'm not in a mood to suppress the change, even if it isn't great.
| @@ -1332,16 +1333,14 @@ mod tests { | |||
| let events = neqo_trans_conn.events(); | |||
| let mut stop_sending_event_found = false; | |||
| for e in events { | |||
There was a problem hiding this comment.
This is a common pattern. I was uncertain about whether to change this to use Iterator::any, which would be better for looking for the event. But that would be lots of typing.
it seems |
I went with something a little broader than that. |
Oh, it does: |
VS Code runs clippy on tests. I don't know how to do that from the command line (or else I would change our CI setup as well), but these are the problems I found and fixed.
The only thing I didn't fix were a couple of functions that were past the cognitive complexity limit.