chore: make url crate a workspace dependency #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
martinthomson
approved these changes
Nov 6, 2024
larseggert
approved these changes
Nov 6, 2024
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
force-pushed
the
url-workspace-dep
branch
from
e854a93
to
a9a37ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36447 36447
=======================================
Hits 34768 34768
Misses 1679 1679 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to b61136f. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [98.674 ns 99.014 ns 99.362 ns]
change: [-1.3483% -0.9129% -0.4563%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.82 ns 117.18 ns 117.56 ns]
change: [-1.0839% -0.5698% -0.1468%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.89 ns 117.56 ns 118.27 ns]
change: [-0.5775% +0.4108% +1.6077%] (p = 0.55 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.833 ns 98.000 ns 98.175 ns]
change: [-0.5760% +0.1817% +0.9787%] (p = 0.67 > 0.05)
RxStreamOrderer::inbound_frame(): 💔 Performance has regressed. time: [113.13 ms 113.28 ms 113.50 ms]
change: [+1.2592% +1.5101% +1.7446%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.498 ms 26.546 ms 27.610 ms]
change: [-5.5086% -0.1821% +5.8251%] (p = 0.95 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.194 ms 35.894 ms 37.641 ms]
change: [-5.0996% +1.1563% +8.0335%] (p = 0.73 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [25.710 ms 26.501 ms 27.293 ms]
change: [+0.5285% +4.6287% +9.0606%] (p = 0.03 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [40.807 ms 42.951 ms 45.145 ms]
change: [-4.7161% +2.2885% +9.3497%] (p = 0.51 > 0.05)
1-conn/1-100mb-resp/mtu-1500 (aka. Download)/client: 💔 Performance has regressed. time: [984.96 ms 993.28 ms 1.0015 s]
thrpt: [99.852 MiB/s 100.68 MiB/s 101.53 MiB/s]
change:
time: [+3.2202% +4.5333% +5.8327%] (p = 0.00 < 0.05)
thrpt: [-5.5112% -4.3367% -3.1198%]
1-conn/10_000-parallel-1b-resp/mtu-1500 (aka. RPS)/client: No change in performance detected. time: [319.76 ms 323.01 ms 326.28 ms]
thrpt: [30.648 Kelem/s 30.959 Kelem/s 31.273 Kelem/s]
change:
time: [-2.2765% -0.8713% +0.5580%] (p = 0.23 > 0.05)
thrpt: [-0.5549% +0.8790% +2.3295%]
1-conn/1-1b-resp/mtu-1500 (aka. HPS)/client: No change in performance detected. time: [33.388 ms 33.546 ms 33.711 ms]
thrpt: [29.664 elem/s 29.809 elem/s 29.951 elem/s]
change:
time: [-1.4702% -0.6784% +0.0979%] (p = 0.10 > 0.05)
thrpt: [-0.0978% +0.6830% +1.4921%]
1-conn/1-100mb-resp/mtu-1500 (aka. Upload)/client: No change in performance detected. time: [1.7066 s 1.7297 s 1.7536 s]
thrpt: [57.026 MiB/s 57.814 MiB/s 58.595 MiB/s]
change:
time: [-2.3060% -0.5424% +1.2359%] (p = 0.54 > 0.05)
thrpt: [-1.2208% +0.5453% +2.3605%]
1-conn/1-100mb-resp/mtu-65536 (aka. Download)/client: Change within noise threshold. time: [111.26 ms 111.47 ms 111.69 ms]
thrpt: [895.36 MiB/s 897.09 MiB/s 898.83 MiB/s]
change:
time: [-1.1141% -0.7835% -0.4438%] (p = 0.00 < 0.05)
thrpt: [+0.4458% +0.7897% +1.1266%]
1-conn/10_000-parallel-1b-resp/mtu-65536 (aka. RPS)/client: No change in performance detected. time: [315.84 ms 319.42 ms 323.00 ms]
thrpt: [30.960 Kelem/s 31.307 Kelem/s 31.661 Kelem/s]
change:
time: [-0.9584% +0.6279% +2.1510%] (p = 0.43 > 0.05)
thrpt: [-2.1057% -0.6240% +0.9677%]
1-conn/1-1b-resp/mtu-65536 (aka. HPS)/client: No change in performance detected. time: [33.818 ms 33.989 ms 34.175 ms]
thrpt: [29.261 elem/s 29.421 elem/s 29.570 elem/s]
change:
time: [-1.0830% -0.2000% +0.6660%] (p = 0.65 > 0.05)
thrpt: [-0.6616% +0.2004% +1.0949%]
1-conn/1-100mb-resp/mtu-65536 (aka. Upload)/client: No change in performance detected. time: [293.68 ms 371.86 ms 463.37 ms]
thrpt: [215.81 MiB/s 268.92 MiB/s 340.50 MiB/s]
change:
time: [-14.956% +15.847% +54.621%] (p = 0.36 > 0.05)
thrpt: [-35.326% -13.679% +17.587%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2219.